Re: [PATCHES] WIP patch - INSERT-able log statements

On 2/19/07, Alvaro Herrera <alvherre(at)commandprompt(dot)com> wrote:
> Guillaume Smet escribió:
> > On 2/19/07, Alvaro Herrera <alvherre(at)commandprompt(dot)com> wrote:
> > >So add the session ID (%c) to log_line_prefix.
> >
> > It could work if log_line_prefix was added before every line but it's
> > definitely not the case:
> > myuser mydb 45d9d615.4abe LOG: duration : 185.223 ms, statement : SELECT *
> > FROM lieu
> > LIMIT 10;
> > if you execute:
> > SELECT *
> > FROM lieu
> > LIMIT 10;
>
> Interesting. I wonder why didn't you report this as a bug before?
> Maybe we could have discussed it and fixed it.

Perhaps because I thought it was not really a bug but the intended behaviour.
Syslog has the same behaviour and it's quite logical when you consider
how queries are logged (I've spent a few hours in the logging code).
Syslog has exactly the same behaviour but adds the necessary context
information.
I'm pretty sure I have explained the problem a few times on the lists
though but perhaps it was just on IRC.

From the feedback I have on pgFouine, very few people think it's a
real problem, probably because they don't use query logging as we do:
our production servers have it enabled all the time and we have a high
load on them so this particular case is a common case for us.

(Second try to move this discussion to -hackers)

--
Guillaume