| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bill Moran <wmoran(at)collaborativefusion(dot)com>, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] [PATCHES] Patch to log usage of |
| Date: | 2007-01-12 16:44:39 |
| Message-ID: | 200701121644.l0CGidw14924@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Simon Riggs wrote:
> On Thu, 2007-01-11 at 12:37 -0500, Bruce Momjian wrote:
>
> > The trace probe was incorrect
>
> Yes, incomplete, no doubt. On that point you were 100% right to reject.
>
> > and kind of at an odd place. I don't
> > think we want to go down the road of throwing trace in everwhere, do we?
> > I would like to see a more systematic approach to it.
>
> I guess my systematic approach was to add PG_TRACE to all new log points
> from now on, so we have a choice of which trace/log mechanism to use.
I think the right approach is to look at our existing code and come up
with places we want them, and add them in one shot. Doing thing
in small parts doesn't work too well with a project this size.
--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | markwkm | 2007-01-12 16:53:21 | Re: ideas for auto-processing patches |
| Previous Message | Michael Enke | 2007-01-12 16:38:28 | Re: copy table from file: with row replacement? |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2007-01-12 17:58:53 | Re: [HACKERS] [PATCHES] Patch to log usage oftemporary files |
| Previous Message | Alvaro Herrera | 2007-01-12 16:22:59 | Re: [GENERAL] Corrupt database? 8.1/FreeBSD6.0 |