| From: | "Simon Riggs" <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | "Bruce Momjian" <bruce(at)momjian(dot)us> |
| Cc: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Bill Moran" <wmoran(at)collaborativefusion(dot)com>, <pgsql-hackers(at)postgresql(dot)org>, "Andrew Dunstan" <andrew(at)dunslane(dot)net>, <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] [PATCHES] Patch to log usage of temporary files |
| Date: | 2007-01-11 22:45:10 |
| Message-ID: | 1168555510.3990.29.camel@silverbirch.site |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
On Thu, 2007-01-11 at 12:37 -0500, Bruce Momjian wrote:
> The trace probe was incorrect
Yes, incomplete, no doubt. On that point you were 100% right to reject.
> and kind of at an odd place. I don't
> think we want to go down the road of throwing trace in everwhere, do we?
> I would like to see a more systematic approach to it.
I guess my systematic approach was to add PG_TRACE to all new log points
from now on, so we have a choice of which trace/log mechanism to use.
I'm happy with everything but the portability of DTrace, however I'm
fond of the idea of sowing seeds for the time when other solutions will
work also.
I've a bag of PG_TRACE trace points to add sometime soon.
--
Simon Riggs
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2007-01-11 22:49:11 | Re: [HACKERS] [PATCHES] Patch to log usage of temporary files |
| Previous Message | markwkm | 2007-01-11 22:35:13 | O_DIRECT, or madvise and/or posix_fadvise |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2007-01-11 22:49:11 | Re: [HACKERS] [PATCHES] Patch to log usage of temporary files |
| Previous Message | Magnus Hagander | 2007-01-11 21:36:11 | vcbuild - conditional regeneration |