Re: Gen_fmgrtab.sh fails with LANG=et_EE

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-patches(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Marko Kreen" <markokr(at)gmail(dot)com>
Subject: Re: Gen_fmgrtab.sh fails with LANG=et_EE
Date: 2006-09-05 19:06:53
Message-ID: 200609052106.54198.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> "Marko Kreen" <markokr(at)gmail(dot)com> writes:
> > I grepped around source and did not find other instances of this.
> > The A-Z experssion was only in perl scripts or in configure and
> > configure should be fine as it explicitly resets locale.
>
> Why not do the same in Gen_fmgrtab.sh? A quick LANG=C seems less
> invasive than this.

Well, the line of code is

cpp_define=`echo $OIDSFILE | tr abcdefghijklmnopqrstuvwxyz ABCDEFGHIJKLMNOPQRSTUVWXYZ | sed -e 's/[^A-Z]/_/g'`

so it ought to be pretty obvious what the correct solution for the
problem "character ranges are locale-dependent" is.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2006-09-05 19:10:05 Re: Ding-dong, contrib is dead ...
Previous Message Tom Lane 2006-09-05 19:05:03 Re: Where is hstore?

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-09-05 19:11:38 Re: XML syntax patch
Previous Message Tom Lane 2006-09-05 16:31:58 Re: ISBN/ISSN/ISMN/EAN13 module