Re: ecpg test suite

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, Rocco Altier <RoccoA(at)Routescape(dot)com>, PostgreSQL Hacker <pgsql-hackers(at)postgresql(dot)org>, joe(at)mcknight(dot)de
Subject: Re: ecpg test suite
Date: 2006-08-03 14:54:35
Message-ID: 20060803145435.GA2500@1
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 03, 2006 at 09:47:27AM -0400, Tom Lane wrote:
> While init.pgc no longer fails outright, it still generates a pile of
> unsightly compiler warnings, eg on Fedora 5 (gcc 4.1.1)
> ...
> I find this really unacceptable. There is no other part of the Postgres
> tree besides ecpg that generates any warnings at all.

Tom, keep in mind that we are working on this. The tests were originally
just some files I used to develop with. We are now making them become
part of the source tree. The warnings should be gone by now, except for
the ECPG warning that is supposed to come out. Maybe we remove that
line.

Joachim didn't want me to commit his SoC stuff before he finishes work,
but I felt this is the better way because we get some testing on other
architectures/OSes so everything should be up and running come release
time.

> diff: `-3' option is obsolete; omit it
> diff: Try `diff --help' for more information.

Strange, works well on my Linux system. However, I tried correcting the
option but I'm unsure if it works for you now since both versions worked
for me.

> Regression.diffs is empty, possibly because of the incorrect
> diff invocation hinted at by the last message, but looking into
> the results directory makes it look like you've not got everything on
> the same page about which port number to use:
>
> > [NO_PID]: connect: could not open database connectdb on localhost port 55432 for user connectuser in line 41
> > could not connect to server: Connection refused
> > Is the server running on host "localhost" and accepting
> > TCP/IP connections on port 55432?
>
> That's not the port the temp postmaster is listening on; I suspect
> you've got some hard-wired assumption in there that the user hasn't
> specified a nonstandard --port option to configure.
>
> I find it disturbing that the regression test script doesn't mention having
> shut down the temp postmaster, too.

No idea. Joachim?

Michael
--
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-08-03 14:58:10 Re: Values list-of-targetlists patch for comments (was Re: [PATCHES]
Previous Message Bruce Momjian 2006-08-03 14:40:19 Re: pg_terminate_backend