Re: pg_regress breaks on msys

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_regress breaks on msys
Date: 2006-07-19 17:02:38
Message-ID: 200607191702.k6JH2cq04475@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> In src/include/port.h we have
>
> /*
> * Win32 needs double quotes at the beginning and end of system()
> * strings. If not, it gets confused with multiple quoted strings.
> * It also requires double-quotes around the executable name and
> * any files used for redirection. Other args can use single-quotes.
> *
> * See the "Notes" section about quotes at:
> * http://home.earthlink.net/~rlively/MANUALS/COMMANDS/C/CMD.HTM
> */
>
> The referenced link seems to be dead :-( but AFAICS the pg_regress code
> is following the stated rules. Also, how is it getting past the "make
> install" step which is quoting things just the same? Puzzling.

I found the description somewhere else and copied it into our header
file:

* From http://www.computerhope.com/cmd.htm:
*
* 1. If all of the following conditions are met, then quote characters
* on the command line are preserved:
*
* - no /S switch
* - exactly two quote characters
* - no special characters between the two quote characters, where special
* is one of: &<>()@^|
* - there are one or more whitespace characters between the the two quote
* characters
* - the string between the two quote characters is the name of an
* executable file.
*
* 2. Otherwise, old behavior is to see if the first character is a quote
* character and if so, strip the leading character and remove the last
* quote character on the command line, preserving any text after the last
* quote character.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-07-19 17:12:04 Re: AUTOCOMMIT currently doesn't handle non-transactional commands very well
Previous Message Greg Stark 2006-07-19 16:40:58 Re: How to refer to standard functions?

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2006-07-19 17:06:16 Re: pgcrypto merge cleanup
Previous Message Tom Lane 2006-07-19 16:27:01 Re: pg_regress breaks on msys