Re: longjmp in psql considered harmful

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: longjmp in psql considered harmful
Date: 2006-06-11 19:19:35
Message-ID: 20060611191935.GD20757@svana.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jun 11, 2006 at 02:57:38PM -0400, Tom Lane wrote:
> Martijn van Oosterhout <kleptog(at)svana(dot)org> writes:
> > As it states in the comment, you can't remove the longjump because
> > it's the only way to break out of the read() call when using BSD signal
> > semantics (unless you're proposing non-blocking read+select()). So the
> > patch sets up the sigjump just before the read() and allows the routine
> > to return. If you're not waiting for read(), no sigjump is done.
>
> I think you're missing my point, which is: do we need control-C to
> force a break out of that fgets at all?

If you're asking me, yes. I use it a lot and would miss it if it were
gone. Is there another shortcut for "abort current command and don't
store in history but don't clear it from the screen"?

Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2006-06-11 19:21:43 Re: longjmp in psql considered harmful
Previous Message Tom Lane 2006-06-11 19:03:39 Re: pl/tcl regression failed