Re: Krb5 & multiple DB connections

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Krb5 & multiple DB connections
Date: 2006-02-12 20:06:06
Message-ID: 200602122006.k1CK66d11562@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


Is this something we need for 8.1.X?

---------------------------------------------------------------------------

Bruce Momjian wrote:
>
> Your patch has been added to the PostgreSQL unapplied patches list at:
>
> http://momjian.postgresql.org/cgi-bin/pgpatches
>
> It will be applied as soon as one of the PostgreSQL committers reviews
> and approves it.
>
> ---------------------------------------------------------------------------
>
>
> Stephen Frost wrote:
> > Greetings,
> >
> > * Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> > > I've now tested this patch at home w/ 8.2HEAD and it seems to fix the
> > > bug. I plan on testing it under 8.1.2 at work tommorow with
> > > mod_auth_krb5, etc, and expect it'll work there. Assuming all goes
> > > well and unless someone objects I'll forward the patch to -patches.
> > > It'd be great to have this fixed as it'll allow us to use Kerberos to
> > > authenticate to phppgadmin and other web-based tools which use
> > > Postgres.
> >
> > While playing with this patch under 8.1.2 at home I discovered a
> > mistake in how I manually applied one of the hunks to fe-auth.c.
> > Basically, the base code had changed and so the patch needed to be
> > modified slightly. This is because the code no longer either has a
> > freeable pointer under 'name' or has 'name' as NULL.
> >
> > The attached patch correctly frees the string from pg_krb5_authname
> > (where it had been strdup'd) if and only if pg_krb5_authname returned
> > a string (as opposed to falling through and having name be set using
> > name = pw->name;). Also added a comment to this effect.
> > Please review.
> >
> > Thanks,
> >
> > Stephen
>
> [ Attachment, skipping... ]
>
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 6: explain analyze is your friend
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
> + If your life is a hard drive, | 13 Roberts Road
> + Christ can be your backup. | Newtown Square, Pennsylvania 19073
>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
> choose an index scan if your joining column's datatypes do not
> match
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Hallgren 2006-02-12 20:13:07 Re: User Defined Types in Java
Previous Message Bruce Momjian 2006-02-12 20:05:09 Re: Krb5 & multiple DB connections

Browse pgsql-patches by date

  From Date Subject
Next Message Stephen Frost 2006-02-12 20:29:02 Re: Krb5 & multiple DB connections
Previous Message Bruce Momjian 2006-02-12 20:05:09 Re: Krb5 & multiple DB connections