ALTER CONSTRAINT RENAME patch reverted

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, joe(at)mcknight(dot)de, simon(at)2ndquadrant(dot)com
Subject: ALTER CONSTRAINT RENAME patch reverted
Date: 2006-02-12 19:13:51
Message-ID: 200602121913.k1CJDpi11660@candle.pha.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> This patch appears seriously broken, in particular every routine I
> >> looked at contained incorrect locking assumptions. Nor do I care
> >> for using pg_depend for the purposes it's being used for here.
>
> > OK, how do we proceed? Revert or apply a second patch?
>
> I'd say revert; the patch is going to need significant rework.

OK, patch reverted. Updated version attached. Please adjust and
resubmit. Thanks.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 23.2 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message James William Pye 2006-02-12 19:18:28 python - pq: Get rid of the superfluous 'Ignition' message.
Previous Message Bruce Momjian 2006-02-12 19:13:19 pgsql: Not done: > o %Allow ALTER TABLE ...

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-02-12 19:24:09 Re: Patch to readme
Previous Message Sergey E. Koposov 2006-02-12 17:34:26 Re: patch fixing the old RETURN NEXT bug