Re: pgsql: Code review for spi_query/spi_fetchrow patch: handle errors

From: David Fetter <david(at)fetter(dot)org>
To: Tom Lane <tgl(at)svr1(dot)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Code review for spi_query/spi_fetchrow patch: handle errors
Date: 2005-10-18 18:28:16
Message-ID: 20051018182816.GA22789@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Oct 18, 2005 at 02:13:14PM -0300, Tom Lane wrote:
> Log Message:
> -----------
> Code review for spi_query/spi_fetchrow patch: handle errors sanely,
> avoid leaking memory. I would add a regression test for error
> handling except it seems eval{} can't be used in unprivileged plperl
> :-(

What would you be using the eval{} to do?

Cheers,
D
--
David Fetter david(at)fetter(dot)org http://fetter.org/
phone: +1 510 893 6100 mobile: +1 415 235 3778

Remember to vote!

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2005-10-18 20:38:58 pgsql: Code review for regexp_replace patch.
Previous Message Tom Lane 2005-10-18 17:13:14 pgsql: Code review for spi_query/spi_fetchrow patch: handle errors