Re: pgsql: Code review for spi_query/spi_fetchrow patch: handle errors

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Fetter <david(at)fetter(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Code review for spi_query/spi_fetchrow patch: handle errors
Date: 2005-10-18 20:45:11
Message-ID: 13698.1129668311@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

David Fetter <david(at)fetter(dot)org> writes:
> On Tue, Oct 18, 2005 at 02:13:14PM -0300, Tom Lane wrote:
>> Log Message:
>> -----------
>> Code review for spi_query/spi_fetchrow patch: handle errors sanely,
>> avoid leaking memory. I would add a regression test for error
>> handling except it seems eval{} can't be used in unprivileged plperl
>> :-(

> What would you be using the eval{} to do?

Catch the error inside the Perl function.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message User Xzilla 2005-10-18 20:51:49 wikipedia - wikipgedia: remove obsolete files
Previous Message Tom Lane 2005-10-18 20:38:58 pgsql: Code review for regexp_replace patch.