Re: [HACKERS] Fix PID file location?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)surnet(dot)cl>, josh(at)agliodbs(dot)com, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Fix PID file location?
Date: 2005-06-04 18:14:30
Message-ID: 200506041814.j54IEUK16349@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Is reading postgresql.conf
> > from pg_ctl without a parser really accurate?
>
> The brute-force solution is to duplicate guc-file.l.
>
> That seems pretty ugly but in the long run it might be the most
> maintainable solution. We eventually gave up trying to have a
> cut-rate SQL lexer in psql, and duplicated parser/scan.l.
> Might be best to just go for that solution up front in this case.

Added to TODO:

> * Allow pg_ctl to work properly with configuration files located outside
> the PGDATA directory
>
> pg_ctl can not read the pid file because it isn't located in the
> config directory but in the PGDATA directory. The solution is to
> allow pg_ctl to read and understand postgresql.conf to find the
> data_directory value.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2005-06-04 19:45:57 Re: WAL bypass for CTAS
Previous Message Bruce Momjian 2005-06-04 17:52:16 Re: ARRAY() returning NULL instead of ARRAY[] resp. {}

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-06-04 19:12:15 Re: Server instrumentation: pg_terminate_backend, pg_reload_conf
Previous Message Bruce Momjian 2005-06-04 17:52:16 Re: ARRAY() returning NULL instead of ARRAY[] resp. {}