From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Philip Warner <pjw(at)rhyme(dot)com(dot)au> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_restore (libpq? parser?) bug in 8 |
Date: | 2004-08-17 17:10:39 |
Message-ID: | 200408171710.i7HHAdI22280@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Added to open items list:
* fix dollar quoting problems in pg_restore
---------------------------------------------------------------------------
Philip Warner wrote:
>
> > CREATE FUNCTION xxx() RETURNS integer
> > AS $$ begin return 1;
> >2004-08-12 01:38:48 EST<zzz,birds>: ERROR: unterminated dollar-quoted
> >string at or near "$$ begin return 1;" at character 115
>
>
> Just realized the problem; pg_restore uses a trivial parser to work out
> when statements start/end. It knows about quotes but not about dollar-quotes.
>
>
>
> ----------------------------------------------------------------
> Philip Warner | __---_____
> Albatross Consulting Pty. Ltd. |----/ - \
> (A.B.N. 75 008 659 498) | /(@) ______---_
> Tel: (+61) 0500 83 82 81 | _________ \
> Fax: (+61) 03 5330 3172 | ___________ |
> Http://www.rhyme.com.au | / \|
> | --________--
> PGP key available upon request, | /
> and from pgp.mit.edu:11371 |/
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-08-17 17:14:45 | Re: Does psql use nested transactions? |
Previous Message | Bruce Momjian | 2004-08-17 16:53:56 | Re: [HACKERS] libpq problem |