Re: pltcl - "Cache lookup for attribute" error - version

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Jan Wieck <JanWieck(at)Yahoo(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Patrick Samson <p_samson(at)Yahoo(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: pltcl - "Cache lookup for attribute" error - version
Date: 2004-01-26 17:39:37
Message-ID: 200401261739.i0QHdbP06572@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Jan Wieck wrote:
> Tom Lane wrote:
>
> > Jan Wieck <JanWieck(at)Yahoo(dot)com> writes:
> >> When assigning a tuple to an array, PL/Tcl creates one extra array
> >> element .tupno telling the SPI_tuptable index of the result tuple. I
> >> think I originally planned to have more of these critters ... but
> >> probably never really needed them. It is in there since 6.3!
> >
> >> Bottom line is, if one has a trigger, and inside the trigger he does an
> >> SPI_exec, fetches a tuple into an array and then returns [array get x]
> >> instead of new or old ... so from the back through the right chest into
> >> the left eye ... then it will fail if the .tupno isn't filtered out.
> >
> > Hm. Perhaps we should tighten the test to reject only ".tupno", rather
> > than any name starting with dot?
>
> Man you have worries ... aren't people who use identifiers with a
> leading dot supposed to have problems? What about changing it to ..
> instead? I mean, how does such a thing look like?
>
> SELECT ".. some column .." FROM ".. the schema ..".".. a table .."
> WHERE ".. the schema ..".".. a table ..".".. some column .."
> IN ('.oh.', '.give.', '.me.', '.a.', '.break!');
>
> If you like to, tighten it.

Jan, if I understand correctly, I agree with Tom. It seems strange to
add a restriction on indentifiers in pl/tcl that doesn't exist in any of
the other interfaces.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-01-26 17:43:21 Re: pltcl - "Cache lookup for attribute" error - version
Previous Message Neil Conway 2004-01-26 17:30:47 Re: Examples for PREPARE/EXECUTE docs