Re: src/bin/psql/input.c

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Rod Taylor <rbt(at)rbt(dot)ca>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: src/bin/psql/input.c
Date: 2003-07-25 19:27:10
Message-ID: 200307251927.h6PJRAM28116@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Patch applied. Thanks.

---------------------------------------------------------------------------

Rod Taylor wrote:
-- Start of PGP signed section.
> On Wed, 2003-06-25 at 11:26, Tom Lane wrote:
> > Rod Taylor <rbt(at)rbt(dot)ca> writes:
> > > It seems that readline() on my system (FreeBSD 4.8) isn't declared to
> > > take the prompt as a const. Thus, remove const from gets_interactive()
> > > to remove the warning.
> >
> > I think it would be a lot cleaner to just put a cast to char * into the
> > readline call (with a note about why).
>
> Ok.. that works.
>
> I must say it's a little strange being able to take a constant and say
> its no longer constant anymore -- but I suppose it's no different than
> defining then undefining pre-processor constants.
>
> --
> Rod Taylor <rbt(at)rbt(dot)ca>
>
> PGP Key: http://www.rbt.ca/rbtpub.asc

[ Attachment, skipping... ]
-- End of PGP section, PGP failed!

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2003-07-25 19:33:45 Re: Datetime patch
Previous Message Tom Lane 2003-07-25 19:24:44 Re: UPDATED Patch for adding DATACUBE operator