Re: src/bin/psql/input.c

From: Rod Taylor <rbt(at)rbt(dot)ca>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: src/bin/psql/input.c
Date: 2003-06-26 00:30:56
Message-ID: 1056587455.56717.69.camel@jester
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Wed, 2003-06-25 at 11:26, Tom Lane wrote:
> Rod Taylor <rbt(at)rbt(dot)ca> writes:
> > It seems that readline() on my system (FreeBSD 4.8) isn't declared to
> > take the prompt as a const. Thus, remove const from gets_interactive()
> > to remove the warning.
>
> I think it would be a lot cleaner to just put a cast to char * into the
> readline call (with a note about why).

Ok.. that works.

I must say it's a little strange being able to take a constant and say
its no longer constant anymore -- but I suppose it's no different than
defining then undefining pre-processor constants.

--
Rod Taylor <rbt(at)rbt(dot)ca>

PGP Key: http://www.rbt.ca/rbtpub.asc

Attachment Content-Type Size
input.c.patch text/x-patch 659 bytes

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Joe Conway 2003-06-26 01:09:42 Re: [HACKERS] allowed user/db variables
Previous Message Tom Lane 2003-06-25 23:52:56 Re: [HACKERS] allowed user/db variables