Re: psql patch (2)

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Jeroen T(dot) Vermeulen" <jtv(at)xs4all(dot)nl>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: psql patch (2)
Date: 2003-03-20 15:45:16
Message-ID: 200303201545.h2KFjGJ28121@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


OK, fixed as you suggested.

---------------------------------------------------------------------------

Jeroen T. Vermeulen wrote:
> On Thu, Mar 20, 2003 at 01:45:31AM -0500, Bruce Momjian wrote:
> >
> > I also adjusted this:
> >
> > + char parse_char(char **buf)
> > + {
> > + long l;
> > +
> > + l = strtol(*buf, buf, 0);
> > + (*buf)--;
> > + return (char)l;
> > + }
> > +
> >
> > I added the parens around 'buf' because the compiler was saying
> > statement has no effect. Is this correct?
>
> I don't remember what this function does, but you could also write
> '--*buf;' to save on parentheses (and do your bit for the environment).
>
>
> Jeroen
>
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-03-20 15:45:54 Re: to_char PL/MI fix
Previous Message Jeroen T. Vermeulen 2003-03-20 15:14:25 Re: psql patch (2)