Re: psql patch (2)

From: "Jeroen T(dot) Vermeulen" <jtv(at)xs4all(dot)nl>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: psql patch (2)
Date: 2003-03-20 15:14:25
Message-ID: 20030320151425.GG28190@xs4all.nl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Thu, Mar 20, 2003 at 01:45:31AM -0500, Bruce Momjian wrote:
>
> I also adjusted this:
>
> + char parse_char(char **buf)
> + {
> + long l;
> +
> + l = strtol(*buf, buf, 0);
> + (*buf)--;
> + return (char)l;
> + }
> +
>
> I added the parens around 'buf' because the compiler was saying
> statement has no effect. Is this correct?

I don't remember what this function does, but you could also write
'--*buf;' to save on parentheses (and do your bit for the environment).

Jeroen

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-03-20 15:45:16 Re: psql patch (2)
Previous Message Karel Zak 2003-03-20 11:17:45 Re: to_char PL/MI fix