Re: [COMMITTERS] pgsql-server/src/test/regress resultmap expect ...

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)postgresql(dot)org>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql-server/src/test/regress resultmap expect ...
Date: 2002-12-13 20:44:27
Message-ID: 200212132044.gBDKiRn04139@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> CVSROOT: /cvsroot
> Module name: pgsql-server
> Changes by: tgl(at)postgresql(dot)org 02/12/13 15:35:57
>
> Modified files:
> src/test/regress: resultmap
> Added files:
> src/test/regress/expected: geometry_1.out
> Removed files:
> src/test/regress/expected: geometry-positive-zeros.out
>
> Log message:
> Admit defeat on the prospect of keeping straight exactly which platforms
> produce which output in the geometry test, even with the problem narrowed
> down to only whether they print minus zero or not. Instead, use
> pg_regress' locale-variant mechanism to automatically consider the test
> to pass if it matches either supplied comparison file. geometry_1.out
> replaces the former geometry-positive-zeros.out.

One issue is how are we going to know when a results file _isn't_ needed
anymore, because we will not be matching regression files against
platforms anymore? Do we need a comment somewhere in the file?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian - CVS 2002-12-13 22:17:57 pgsql-server/src bin/psql/help.c interfaces/li ...
Previous Message Tom Lane 2002-12-13 20:35:57 pgsql-server/src/test/regress resultmap expect ...

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2002-12-13 20:51:52 Re: Big 7.4 items
Previous Message darren 2002-12-13 20:42:45 Re: Big 7.4 items