Re: CLUSTER ALL syntax

From: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: CLUSTER ALL syntax
Date: 2002-11-18 01:31:40
Message-ID: 20021118013140.GA19069@dcc.uchile.cl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Sun, Nov 17, 2002 at 06:43:38PM -0500, Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:

> > > And what about REINDEX? That seems to have a different syntax from the
> > > other two. Seems there should be some consistency.
> >
> > We don't have a REINDEX ALL, and I'm not in a hurry to invent one.
> > (Especially, I'd not want to see Alvaro spending time on that instead
> > of fixing the underlying btree-compaction problem ;-))
>
> My point for REINDEX was a little different. The man pages shows:
>
> REINDEX { DATABASE | TABLE | INDEX } <replaceable
> class="PARAMETER">name</replaceable> [ FORCE ]
>
> where we don't have ALL but we do have DATABASE. Do we need that
> tri-valued secodn field for reindex because you can reindex a table _or_
> and index, and hence DATABASE makes sense? I am just asking.

REINDEX DATABASE is for system indexes only, it's not the same that one
would think of REINDEX alone (which is all indexes on all tables, isn't
it?).

What I don't understand is what are the parameters in the
ReindexDatabase function for. For example, the boolean all is always
false in tcop/utility.c (and there are no other places that the function
is called). Also, the database name is checked to be equal to a
"constant" value, the database name that the standalone backend is
connected to. Why are those useful?

--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"No renuncies a nada. No te aferres a nada"

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-11-18 01:36:04 Re: CLUSTER ALL syntax
Previous Message Tom Lane 2002-11-18 00:30:31 Re: [GENERAL] DECLARE CURSOR

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-11-18 01:36:04 Re: CLUSTER ALL syntax
Previous Message Neil Conway 2002-11-18 00:03:46 per-statement triggers