Re: minor auth code cleanup

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: minor auth code cleanup
Date: 2002-08-27 15:15:46
Message-ID: 200208271515.g7RFFkq24747@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


OK, I added your comment improvements, where appropriate. I also did a
little more cleanup of the connection timeout code.

---------------------------------------------------------------------------

Neil Conway wrote:
> The attached patch makes the following changes:
>
> - add an assertion to check that the size of the packet
> specified in the protocol is the same amount of data that we
> actually read off the wire.
>
> - fix some bizarre indentation & grammar mistake in the newly
> added libpq timeout code. Also make some minor cleanup.
>
> - add a comment noting the intent to replace the fixed size
> user name & database name fields in the protocol with
> variable width ones.
>
> Unless anyone sees a problem, please apply.
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilc(at)samurai(dot)com> || PGP Key ID: DB3C29FC

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2002-08-27 15:16:37 Re: minor auth code cleanup
Previous Message Tom Lane 2002-08-27 15:15:39 Re: minor auth code cleanup