Re: [BUGS] Bug #708: PgTransaction class is broken since 7.2

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Piotr Klaban <post(at)klaban(dot)torun(dot)pl>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, PostgreSQL-interfaces <pgsql-interfaces(at)postgresql(dot)org>
Subject: Re: [BUGS] Bug #708: PgTransaction class is broken since 7.2
Date: 2002-07-13 01:47:13
Message-ID: 200207130147.g6D1lDQ00896@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-interfaces pgsql-patches

Piotr Klaban wrote:
> > > PgTransaction class is broken since 7.2
>
> On Thu, Jul 11, 2002 at 12:41:24PM -0400, Bruce Momjian wrote:
> >
> > OK, would you send us a correcting patch? Thanks.
>
> Thank you for a quick reply.
> Sure. If you do not mind, I will enclosed it with this letter
> directly to you.

This person would like the following patch applied to libpq++ to fix a
problem with pg2xbase. I have attached the bug report and his proposed
patch of removing 'protected' from two methods:

-protected:
ExecStatusType BeginTransaction();
ExecStatusType EndTransaction();

It this acceptable to people?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Attachment Content-Type Size
unknown_filename text/plain 1.3 KB
unknown_filename text/plain 957 bytes

Browse pgsql-interfaces by date

  From Date Subject
Next Message Michael Meskes 2002-07-13 13:26:58 Re: ECPG Questions
Previous Message C. Maj 2002-07-13 00:50:41 Re: pg access links to another postgresdatabase

Browse pgsql-patches by date

  From Date Subject
Next Message Rod Taylor 2002-07-13 05:43:29 GRANT / REVOKE on functions
Previous Message Bruce Momjian 2002-07-13 01:38:47 Re: Prepare xlog for optional oid