| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Brent Verner <brent(at)rcfile(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Douglas Trainor <trainor(at)uic(dot)edu>, pgsql-bugs(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [PATCHES] COPY when 'filename' is a directory |
| Date: | 2002-02-24 02:03:35 |
| Message-ID: | 200202240203.g1O23Z100564@candle.pha.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-patches |
Brent Verner wrote:
> [2002-02-23 20:27] Tom Lane said:
> | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> | > {
> | > + struct stat st;
> | > fp = AllocateFile(filename, PG_BINARY_R);
>
> | > + fclose(fp);
> |
> | This coding is WRONG. You do not use fclose() to release a file
> | opened with AllocateFile.
>
> corrected diff attached.
You are going to feel even more ashamed when you realize you sent a
non-context diff. :-)
I can't apply that. I need diff -c.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2002-02-24 02:11:03 | Re: [PATCHES] COPY when 'filename' is a directory |
| Previous Message | Brent Verner | 2002-02-24 01:59:42 | Re: COPY when 'filename' is a directory |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2002-02-24 02:11:03 | Re: [PATCHES] COPY when 'filename' is a directory |
| Previous Message | Brent Verner | 2002-02-24 01:59:42 | Re: COPY when 'filename' is a directory |