| From: | Brent Verner <brent(at)rcfile(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Douglas Trainor <trainor(at)uic(dot)edu>, pgsql-bugs(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: COPY when 'filename' is a directory |
| Date: | 2002-02-24 01:59:42 |
| Message-ID: | 20020224015942.GA23089@rcfile.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-patches |
[2002-02-23 20:27] Tom Lane said:
| Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
| > {
| > + struct stat st;
| > fp = AllocateFile(filename, PG_BINARY_R);
| > + fclose(fp);
|
| This coding is WRONG. You do not use fclose() to release a file
| opened with AllocateFile.
corrected diff attached.
b
--
"Develop your talent, man, and leave the world something. Records are
really gifts from people. To think that an artist would love you enough
to share his music with anyone is a beautiful thing." -- Duane Allman
| Attachment | Content-Type | Size |
|---|---|---|
| doh.diff | text/plain | 322 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2002-02-24 02:03:35 | Re: [PATCHES] COPY when 'filename' is a directory |
| Previous Message | Brent Verner | 2002-02-24 01:56:22 | Re: COPY when 'filename' is a directory |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2002-02-24 02:03:35 | Re: [PATCHES] COPY when 'filename' is a directory |
| Previous Message | Brent Verner | 2002-02-24 01:56:22 | Re: COPY when 'filename' is a directory |