Re: Explicit config patch 7.2B4

From: Marko Kreen <marko(at)l-t(dot)ee>
To: mlw <markw(at)mohawksoft(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Explicit config patch 7.2B4
Date: 2001-12-18 16:56:16
Message-ID: 20011218165616.GA17656@l-t.ee
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 17, 2001 at 12:56:53PM -0500, mlw wrote:
> Marko Kreen wrote:
> > On Sun, Dec 16, 2001 at 09:35:58AM -0500, mlw wrote:
> > > In the config file there are two more options:
> > >
> > > datadir = '/u01/postgres'
> > > hbaconfig = '/etc/pgsql/pg_hba.conf'

> I will submit a complete patch that includes pg_ident.conf as well.
>
> Here is a question for the great minds here:
>
> If a user has used the "-C" option, as in:
>
> postmaster -C /etc/pgsql/mydb.conf
>
> Should I then, and first, see if there is a "/etc/pgsql/pg_hba.conf" or
> "/etc/pgsql/pg_ident.conf" and use it as an explicit path?

It should search them only if they are not mentioned in .conf, I
guess.

> How about:
>
> postmaster -C /etc/pgsql
>
> Should I then look for:
>
> /etc/pgsql/postgresql.conf
> /etc/pgsql/pg_hba.conf
> /etc/pgsql/pg_ident.conf

One suggestion to you: try to think how different approaches
look when documented. User must be able to predict program
behaviour only by looking at docs. If 3 lines of C add
2 messy paragraphs to docs, then it is probably unnecessary
'feature'. Also what if I say '-C /etc/pgsql/db.conf' and there
is no pg_hba.conf there. It should give error, not go secretly
searching it in $PGDATA.

--
marko

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Oleg Bartunov 2001-12-18 17:05:26 Re: Connection Pooling, a year later
Previous Message Lincoln Yeoh 2001-12-18 16:53:08 Re: Concerns about this release