Re: [HACKERS] To Postgres Devs : Wouldn't changing the selectlimit

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: lockhart(at)fourpalms(dot)org, Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Hackers List <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] To Postgres Devs : Wouldn't changing the selectlimit
Date: 2001-10-23 02:38:29
Message-ID: 200110230238.f9N2cTt11054@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

> Thomas Lockhart <lockhart(at)fourpalms(dot)org> writes:
> > I think Hiroshi's point is the same as mine: discussions of feature
> > changes need to happen on -hackers before being implemented.
>
> Well, IIRC there *was* some discussion about this some months back, and
> no one particularly objected to changing it to be compatible with MySQL.
> That's why Bruce felt free to execute on the TODO item despite being
> so close to beta.
>
> > Subscriptions to other mailing lists should not be required to stay up
> > with mainstream development issues.
>
> Actually, the reason we have an argument now is the other way around:
> some non-hackers people complained when the change notice went by.
> We do have an obligation to users who don't read -hackers.
>
> Given the amount of noise being raised on the issue now, I think the
> better part of valor is to revert to the 7.1 behavior and plan to
> discuss it again for 7.3. But it's not like Bruce did this with no
> warning or discussion.

[ BCC to general ]

I agree. Let me reverse this to 7.1 behavior, and note in the HISTORY
file that LIMIT #,# will be removed in 7.3. That way, people know it is
coming and it gives them one release to fix their queries. I know Tom
wanted it removed right away because it is so confusing but I think we
have enough votes to keep it around, unchanged, for another release.

As to whether we should emit a NOTICE every time LIMIT #,# is used, I
think not, but if people want it I can add it.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Bruce Momjian 2001-10-23 02:51:53 LIMIT TODO item
Previous Message Tom Lane 2001-10-23 02:32:57 Re: [GENERAL] To Postgres Devs : Wouldn't changing the selectlimit

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2001-10-23 02:50:38 Re: Creating unique constraints on OID
Previous Message Tom Lane 2001-10-23 02:32:57 Re: [GENERAL] To Postgres Devs : Wouldn't changing the selectlimit