Re: Beta Monday?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Larry Rosenman <ler(at)lerctr(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>
Subject: Re: Beta Monday?
Date: 2001-09-07 15:01:59
Message-ID: 200109071501.f87F1xX22206@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Fri, Sep 07, 2001 at 10:39:19AM -0400, Bruce Momjian wrote:
> > > Karel Zak <zakkr(at)zf(dot)jcu(dot)cz> writes:
> > > >> But here is the tail of the output:
> > > >> UX:cc: WARNING: debugging and optimization mutually exclusive; -O disabled
> > > >> UX:acomp: ERROR: "encnames.c", line 36: syntax error in macro parameters
> > > > ^^^^^^^^^^^^^
> > >
> > > > #define encdebug(_format, _a...)
> > > > ^^^^^^^^^^^
> > > > line 36
> > >
> > > > I don't see some problem with my gcc. Or I something overlook?
> > >
> > > "..." in macro parameters is a gcc-ism. This code is unportable and
> > > must be fixed.
> >
> > Yes, that stuff can't be done. We do use ## to bind macro params, but
> > we don't do variable-length macro calls. This is debug stuff anyway so
> > I am looking at how to get it compiling right away.
>
> Hmm.. my world is comiled by 'gcc' and I'm still must learning that
> here are some cathedrals and not bazaars only :-) Sorry.
>
> OK, please erase all these debug macros (encdebug). I used it for binary
> search check only. It's not needful. Do you want a patch (but not until
> Monday)?

OK, macros gone. Should compile fine now for people using multibyte.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message bpalmer 2001-09-07 15:18:41 Re: backend hba.c prob
Previous Message Marc G. Fournier 2001-09-07 15:01:46 pgsql/src/backend/utils/mb encnames.c