Re: [current] readline breakage

Peter,

On Sun, Jun 17, 2001 at 12:08:59PM +0200, Peter Eisentraut wrote:
> Jason Tishler writes:
>
> > Shouldn't the declaration for filename_completion_function() be picked up
> > via readline.h? IMO, redeclaring functions especially from an external
> > library (i.e., readline) is generally not considered good programming
> > practice.
>
> It should, but on some systems it evidently isn't. But since on Cygwin a
> correct import/export decorated declaration should be in the header files,
> would a second declaration without those attributes override or otherwise
> interfere with that?

No, after applying the attached patch, Cygwin psql built against readline
4.2 without any problems. After some reflection, this outcome should
have been obvious to me since my previous distributions built fine with
the duplicate (but different) filename_completion_function() declarations.

Note that I did not test this patch against the other three configuration
that I used to test my original patch but I would not anticipate any issues
with these configurations either.

> Otherwise I might have to stick it back covered by some #ifdef's.

The #ifdefs do not appear to be necessary.

Do you want to submit this patch to pgsql-patches or should I?

Thanks,
Jason

--
Jason Tishler
Director, Software Engineering Phone: 732.264.8770 x235
Dot Hill Systems Corp. Fax: 732.264.8798
82 Bethany Road, Suite 7 Email: Jason(dot)Tishler(at)dothill(dot)com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com