Re: failed to compile a C++ SPI function

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: ldm(at)apartia(dot)ch, pgsql-hackers(at)postgresql(dot)org
Subject: Re: failed to compile a C++ SPI function
Date: 2000-10-08 04:02:57
Message-ID: 200010080402.AAA02427@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I am willing to change it to typname. Any comments?
>
> That's hardly the only change you will have to make to get the headers
> to pass through a C++ compiler without complaint. How many existing
> applications do you want to risk breaking?
>
> ParamNo probably isn't a widely used node type, but there are four
> structs with fields named 'typename' and one with a field named 'class'
> just in parsenodes.h.
>
> I think that before we start making changes with C++ cleanness as a
> goal, we should try to get a precise idea of the extent of the changes
> that would be needed, and then estimate how much user code might
> reference the fields we'd need to rename.

Agreed.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2000-10-08 04:11:28 Re: pg_dump, BLOBs and single-table dumps - RFC
Previous Message Bruce Momjian 2000-10-08 04:02:00 Re: Re: [ANNOUNCE] Announce: Release of PyGreSQL version 3.0