| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Useless code in ExecInitModifyTable |
| Date: | 2017-06-22 02:25:43 |
| Message-ID: | 1ed12418-ce9a-471d-dbec-e85b32d71f47@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/06/21 23:52, Robert Haas wrote:
> You're right that there is a comment missing from the function header,
> but it's not too hard to figure out what it should be. Just consult
> the definition of ModifyTable itself:
>
> /* RT indexes of non-leaf tables in a partition tree */
> List *partitioned_rels;
I agree on that point, but I think it's better to add the missing
comment for the create_modifytable_path argument, as proposed in [1].
Best regards,
Etsuro Fujita
[1]
https://www.postgresql.org/message-id/e87c4a6d-23d7-5e7c-e8db-44ed418eb5d1%40lab.ntt.co.jp
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-06-22 02:43:32 | Re: Get stuck when dropping a subscription during synchronizing table |
| Previous Message | Masahiko Sawada | 2017-06-22 02:16:13 | Re: Fix a typo in partition.c |