Re: [HACKERS] MERGE SQL Statement for PG11

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] MERGE SQL Statement for PG11
Date: 2018-04-05 12:18:17
Message-ID: 1c708ad5-ab6d-da12-50d4-2d6fbff3c42e@sigaev.ru
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

> The variable would become unused in non-assert builds. I see that. But simply
> removing it is not a solution and I don't think the code will compile that way.
> We should either rewrite that assertion or put it inside a #ifdef
> ASSERT_CHECKING block or simple remove that assertion because we already check
> for relkind in parse_merge.c. Will check.
>

That is noted by Kyotaro HORIGUCHI
https://www.postgresql.org/message-id/20180405.181730.125855581.horiguchi.kyotaro%40lab.ntt.co.jp

and his suggestion to use special macro looks better for me:
- char relkind;
+ char relkind PG_USED_FOR_ASSERTS_ONLY;

--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jesper Pedersen 2018-04-05 12:19:04 Re: [HACKERS] MERGE SQL Statement for PG11
Previous Message Tomas Vondra 2018-04-05 12:17:10 Re: [PATCH] btree_gin, add support for uuid, bool, name, bpchar and anyrange types