Re: [HACKERS] GUC for cleanup indexes threshold.

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: sawada(dot)mshk(at)gmail(dot)com
Cc: teodor(at)sigaev(dot)ru, a(dot)korotkov(at)postgrespro(dot)ru, simon(at)2ndquadrant(dot)com, y(dot)sokolov(at)postgrespro(dot)ru, pg(at)bowt(dot)ie, andres(at)anarazel(dot)de, robertmhaas(at)gmail(dot)com, david(at)pgmasters(dot)net, amit(dot)kapila16(at)gmail(dot)com, ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com, pgsql-hackers(at)postgresql(dot)org, kuntalghosh(dot)2007(at)gmail(dot)com, pgsql-hackers-owner(at)postgresql(dot)org
Subject: Re: [HACKERS] GUC for cleanup indexes threshold.
Date: 2018-04-05 09:17:30
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


The commit leaves three warnings for
-Wunused-but-set-variable. Two of them are not assertion-only but
really not used at all.

I also found that nodeMerge.c has one such variable.


At Thu, 5 Apr 2018 15:43:55 +0900, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote in <CAD21AoAtYzXeuhPqGw89KxqcJWpSKxWRNkYzyJxAqJHZham==Q(at)mail(dot)gmail(dot)com>
> On Thu, Apr 5, 2018 at 2:40 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > On Thu, Apr 5, 2018 at 1:30 AM, Teodor Sigaev <teodor(at)sigaev(dot)ru> wrote:
> >> Thanks for everyone, pushed with minor editorization
> >>
> >
> > Thank you for committing!
> > I found a typo in nbtpage.c and attached a patch fixes it.
> >
> I also found an incorrect documentation in create_index.sgml as follows.
> <term><literal>vacuum_cleanup_index_scale_factor</literal></term>
> <listitem>
> <para>
> Per-table value for <xref
> linkend="guc-vacuum-cleanup-index-scale-factor"/>.
> </para>
> </listitem>
> </varlistentry>
> I think it should be "Per-index". Attached a patch for fixing it. And
> sorry for missing it at review.
> Regards,

Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
remove_unused_variables_nbt.patch text/x-patch 1.7 KB
remove_unused_variables_nodemerge.patch text/x-patch 461 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2018-04-05 09:24:58 Re: [HACKERS] Add support for tuple routing to foreign partitions
Previous Message Magnus Hagander 2018-04-05 09:07:26 Re: Online enabling of checksums