| From: | surya poondla <suryapoondla4(at)gmail(dot)com> |
|---|---|
| To: | Ian Lawrence Barwick <barwick(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Thom Brown <thom(at)linux(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [PATCH] Rename "getdatabaseencoding()" to "pg_database_encoding()", and document |
| Date: | 2026-07-27 18:10:30 |
| Message-ID: | CAOVWO5qnsvrqmsy2tYQ0Zv=FNj-MBryksjtvMoS3Ha3A24rr7g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi All,
+1 for documenting it.
I took a look at the patch, it applies cleanly to master and the resulting
SGML is well-formed.
The description text mirrors pg_client_encoding()'s existing entry
("Returns current client encoding name."), which seems right to me for
consistency. The declared "name" return type matches pg_proc.dat, too.
It might also be worth mentioning in the description that this returns the
server encoding, i.e. the same value as current_setting('server_encoding').
Feel free to ignore if you'd rather keep the entry minimal.
Regards,
Surya Poondla
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-07-27 18:21:12 | Re: remove_useless_joins vs. bug #19560 |
| Previous Message | Srinath Reddy Sadipiralla | 2026-07-27 17:27:45 | Re: SQL/JSON: JSON_TRANSFORM (SQL standard, subclause 6.44) |