Property graph: fix error handling when dropping non-existent label property

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Property graph: fix error handling when dropping non-existent label property
Date: 2026-04-24 07:32:38
Message-ID: 1DA5D52A-4AFA-426E-83F7-42ED974D682B@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I am testing graph tables today and noticed an improper error message when dropping a property.

Here is a simple repro:
```
evantest=# CREATE TABLE t1 (a int PRIMARY KEY, b int);
CREATE TABLE
evantest=#
evantest=# CREATE PROPERTY GRAPH g
evantest-# VERTEX TABLES (
evantest(# t1
evantest(# LABEL l1 PROPERTIES (a AS p1)
evantest(# LABEL l2 PROPERTIES (b AS p2)
evantest(# );
CREATE PROPERTY GRAPH
evantest=#
evantest=# ALTER PROPERTY GRAPH g
evantest-# ALTER VERTEX TABLE t1
evantest-# ALTER LABEL l1 DROP PROPERTIES (p2);
ERROR: could not find tuple for label property 0
```

This does not look like a normal user-facing SQL error message.

Looking into the code, AlterPropGraph() checks whether the property exists in the graph, but does not check if label property exists. As a result, InvalidOid can be passed to ObjectAddressSet() and then to performDeletion().

The fix is simple, just check the label-property OID before trying to delete it. I also added a regress test.

With the patch, the error becomes:
```
evantest=# ALTER PROPERTY GRAPH g
evantest-# ALTER VERTEX TABLE t1
evantest-# ALTER LABEL l1 DROP PROPERTIES (p2);
ERROR: property graph "g" element "t1" label "l1" has no property "p2"
```

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

Attachment Content-Type Size
v1-0001-Fix-DROP-PROPERTIES-check-for-property-graph-labe.patch application/octet-stream 3.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message wenhui qiu 2026-04-24 07:39:00 Re: New vacuum config to avoid anti wraparound vacuums
Previous Message lakshmi 2026-04-24 07:18:41 Re: ECPG: inconsistent behavior with the document in “GET/SET DESCRIPTOR.”