| From: | Greg Burd <greg(at)burd(dot)me> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: [PATCH] Add tests for Bitmapset |
| Date: | 2025-09-18 18:50:45 |
| Message-ID: | 1D776AE2-6027-4494-846F-B50B68B4356C@greg.burd.me |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello hackers, :)
Thanks for all the feedback and time spent reviewing this patch. I
switched out the encode/decode functions to use the nodeToString() and
stringToNode() functions and change all the SQL testing function
signatures to TEXT from BYTEA. This exercises more code and that's good
for testing purposes. I took out the code that checks the hash values,
I can't think of a reason that should cause a future failure should that
change and output different values. I re-integrated the earlier random
testing function along with the newer code. I'm not sure this buys us
much if anything.
coverage: HEAD v7
lines......: 87.1 90.5 +3.4%
functions..: 100.0 100.0 +0.0%
branches...: 63.5 75.9 +12.4%
best.
-greg
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Add-a-module-that-tests-Bitmapset.patch | application/octet-stream | 94.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2025-09-18 19:05:52 | Re: PG 18 relnotes and RC1 |
| Previous Message | Nazir Bilal Yavuz | 2025-09-18 18:49:21 | Re: Updating IPC::Run in CI? |