| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Trivial Fix: use palloc_array/repalloc_array for BufFile file arrays |
| Date: | 2025-12-25 03:34:48 |
| Message-ID: | 1D199FA4-C146-493B-B29A-A1BF1084DBBC@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Dec 25, 2025, at 11:12, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
> Hi Hackers,
>
> I noticed this error while working on [1].
>
> In BufFile, the fields is claimed as an array:
> ```
> struct BufFile
> {
> File *files; /* palloc'd array with numFiles entries */
> ```
>
> However, it’s allocated by palloc_object():
> ```
> file->files = palloc_object(File);
> ```
>
> And reallocated by repalloc():
> ```
> file->files = (File *) repalloc(file->files,
> (file->numFiles + 1) * sizeof(File));
> ```
>
> This trivial patch just changes to use palloc_array/repalloc_array, which makes the intent clearer.
>
> Best regards,
> --
> Chao Li (Evan)
> HighGo Software Co., Ltd.
> https://www.highgo.com/
>
>
>
>
> <v1-0001-Use-palloc_array-repalloc_array-for-BufFile-file-.patch>
Sorry for missing the reference of [1]:
[1] https://postgr.es/m/aUStrqoOCDRFAq1M@paquier.xyz
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2025-12-25 05:05:51 | Re: Refactor replication origin state reset helpers |
| Previous Message | Zhijie Hou (Fujitsu) | 2025-12-25 03:16:34 | RE: doc: update the default of data checksums in the doc of pg_rewind |