Re: [HACKERS] Current source from CVS won't compile.

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: Mike Mascari <mascarim(at)yahoo(dot)com>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Current source from CVS won't compile.
Date: 1999-10-26 17:38:12
Message-ID: 199910261738.NAA28034@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > Can we use only NULL, and not '' please? Seems clearer. I don't like
> > us of '' for any special handling. Thanks.
> >
> > --
> > Bruce Momjian | http://www.op.net/~candle
> > maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> > + If your life is a hard drive, | 830 Blythe Avenue
> > + Christ can be your backup. | Drexel Hill, Pennsylvania
> > 19026
> >
>
> I agree with you, an empty string is a goofy way to drop a comment.
> The only reason I did it that way was because that's how Oracle does
> it (heck, why not create comment on, drop comment on). The question is,
> what should the behavior be when a user supplies an empty string?
>
> COMMENT ON TABLE employees IS '';
>
> Should the above add an empty comment to pg_description?

OK, I like the compatability issue. Let's leave both as dropping
comments, but only document the NULL case. SGML already updated.

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tim Holloway 1999-10-26 23:14:01 Re: [HACKERS] Logging - pg_options format change?
Previous Message Mike Mascari 1999-10-26 17:16:19 Re: [HACKERS] Current source from CVS won't compile.