Re: [HACKERS] psql and comments

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: Thomas Lockhart <lockhart(at)alumni(dot)caltech(dot)edu>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Postgres Hackers List <hackers(at)postgreSQL(dot)org>
Subject: Re: [HACKERS] psql and comments
Date: 1999-10-07 16:43:48
Message-ID: 199910071643.MAA02150@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > > The following example shows psql correctly clearing its input buffer
> > > when a line containing *only* a comment is seen, but not completely
> > > clearing the buffer (or not realizing that it is cleared; note the
> > > changed prompt) if the comment is at the end of a valid query.
> > >
> > > postgres=> -- comment
> > > postgres=> select 'hi'; -- comment
> > > ?column?
> > > --------
> > > hi
> > > (1 row)
> > >
> > > postgres->
> > But aren't they _in_ a new statement, that begins with '--'?
>
> ?? Sure, that's what psql thinks. But the first case shown above
> should also begin a new statement, changing the prompt (it doesn't,
> because after stripping the comment there are zero blanks in the
> line). I don't think that is the right behavior though.
>
> Things aren't a big problem the way they stand, but istm that a
> completely blank line (after stripping single-line comments) may as
> well be the same as an empty line,and that psql could figure that out.

I see your point in the above example. I will wait for the psql/libpq
cleaner-upper to finish, and take a look at it.

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 1999-10-07 16:54:12 Re: [HACKERS] Re: psql and comments
Previous Message Bruce Momjian 1999-10-07 16:41:53 Re: [HACKERS] Re: [GENERAL] Re: [PHP3] Re: PostgreSQL vs Mysql comparison