Re: [GENERAL] more nodeError problems and general view failures!

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: stuart(at)ludwig(dot)ucl(dot)ac(dot)uk (Stuart Rison)
Cc: pgsql-general(at)postgreSQL(dot)org
Subject: Re: [GENERAL] more nodeError problems and general view failures!
Date: 1998-07-09 14:58:36
Message-ID: 199807091458.KAA20474@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

> brecard=> create view on_test2 as
> brecard-> select in_words,number,number * number as "number squared" from
> test1;

Here is the cause. The code could not handle an AS with multiple
words, because of the way it was stored in the rewrite system. This
patch should fix the problem.

Does it fix your second problem too?

---------------------------------------------------------------------------

? src/Makefile.custom
? src/config.log
? src/Makefile.in
? src/config.cache
? src/config.status
? src/GNUmakefile
? src/log
? src/regress.out
? src/Makefile.global
? src/backend/fmgr.h
? src/backend/parse.h
? src/backend/postgres
? src/backend/global1.bki.source
? src/backend/local1_template1.bki.source
? src/backend/global1.description
? src/backend/local1_template1.description
? src/backend/bootstrap/bootparse.c
? src/backend/bootstrap/bootstrap_tokens.h
? src/backend/bootstrap/bootscanner.c
? src/backend/catalog/global1.bki.source
? src/backend/catalog/global1.description
? src/backend/catalog/local1_template1.bki.source
? src/backend/catalog/local1_template1.description
? src/backend/port/Makefile
? src/backend/postmaster/_xlk
? src/backend/utils/Gen_fmgrtab.sh
? src/backend/utils/fmgr.h
? src/backend/utils/fmgrtab.c
? src/bin/cleardbdir/cleardbdir
? src/bin/createdb/createdb
? src/bin/createuser/createuser
? src/bin/destroydb/destroydb
? src/bin/destroyuser/destroyuser
? src/bin/initlocation/initlocation
? src/bin/ipcclean/ipcclean
? src/bin/pg_dump/Makefile
? src/bin/pg_dump/pg_dump
? src/bin/pg_id/pg_id
? src/bin/pg_passwd/pg_passwd
? src/bin/pg_version/Makefile
? src/bin/pg_version/pg_version
? src/bin/pgtclsh/pgtclsh
? src/bin/pgtclsh/pgtksh
? src/bin/psql/Makefile
? src/bin/psql/psql
? src/include/version.h
? src/include/config.h
? src/include/blocksize.h
? src/interfaces/ecpg/lib/Makefile
? src/interfaces/libpgtcl/Makefile
? src/interfaces/libpq/Makefile
? src/interfaces/libpq/libpq.so.1.1
? src/interfaces/libpq/c.h
? src/lextest/lex.yy.c
? src/lextest/lextest
? src/test/regress/regression.diffs
? src/tools/backend/flow.ps
Index: src/backend/nodes/outfuncs.c
===================================================================
RCS file: /usr/local/cvsroot/pgsql/src/backend/nodes/outfuncs.c,v
retrieving revision 1.36
diff -c -r1.36 outfuncs.c
*** outfuncs.c 1998/06/15 19:28:32 1.36
--- outfuncs.c 1998/07/09 14:48:58
***************
*** 660,666 ****
sprintf(buf, " :restypmod %d ", node->restypmod);
appendStringInfo(str, buf);
appendStringInfo(str, " :resname ");
! appendStringInfo(str, node->resname);
sprintf(buf, " :reskey %d ", node->reskey);
appendStringInfo(str, buf);
sprintf(buf, " :reskeyop %u ", node->reskeyop);
--- 660,667 ----
sprintf(buf, " :restypmod %d ", node->restypmod);
appendStringInfo(str, buf);
appendStringInfo(str, " :resname ");
! sprintf(buf,"\"%s\"", node->resname); /* fix for SELECT col AS "my name" */
! appendStringInfo(str, buf);
sprintf(buf, " :reskey %d ", node->reskey);
appendStringInfo(str, buf);
sprintf(buf, " :reskeyop %u ", node->reskeyop);
***************
*** 849,855 ****
appendStringInfo(str, " :arraylow ");
for (i = 0; i < node->arrayndim; i++)
{
! sprintf(buf, " %d ", node->arraylow.indx[i]);
appendStringInfo(str, buf);
}
appendStringInfo(str, " :arrayhigh ");
--- 850,856 ----
appendStringInfo(str, " :arraylow ");
for (i = 0; i < node->arrayndim; i++)
{
! sprintf(buf, " %d ", node->arraylow.indx[i]);
appendStringInfo(str, buf);
}
appendStringInfo(str, " :arrayhigh ");

--
Bruce Momjian | 830 Blythe Avenue
maillist(at)candle(dot)pha(dot)pa(dot)us | Drexel Hill, Pennsylvania 19026
+ If your life is a hard drive, | (610) 353-9879(w)
+ Christ can be your backup. | (610) 853-3000(h)

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Stuart Rison 1998-07-09 16:06:14 Re: [GENERAL] more nodeError problems and general view failures!
Previous Message Oliver Mueschke 1998-07-09 11:41:33 Re: [GENERAL] postgresql website