Re: Missing newlines in error messages

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Missing newlines in error messages
Date: 2016-12-15 15:38:55
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> While poking around the pg_basebackup code, I noticed there are a lot of
> error messages are missing the \n at the end. Most of them are very
> unlikely to happen, but in general I believe all error messages we print to
> stderr from those binaries should have a newline at the end.

> Is that wrong? :)

I think you missed the fact that PQerrorMessage's result will already
end with a newline. So most (not all) of these look OK as they stand.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Ivanov 2016-12-15 15:40:11 Re: Declarative partitioning - another take
Previous Message Wesley Massuda 2016-12-15 15:38:43 Proposal : composite type not null constraints