| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [Patch]Add Graph* node support to expression_tree_mutator |
| Date: | 2026-05-04 15:39:23 |
| Message-ID: | 19895d96-a27a-4e8a-a67f-f6dcf0ed4f82@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 30.04.26 08:44, Ashutosh Bapat wrote:
> On Thu, Apr 30, 2026 at 2:17 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>
>
> Thanks for reviewing the patch.
>
>> Thanks for working on this. I ran into it independently today, and
>> then discovered this thread. In expression_tree_mutator_impl,
>> T_GraphLabelRef can be added to the "Primitive node types with no
>> expression subnodes" section just as was done in
>> expression_tree_walker_impl.
>
> Right. Fixed in the attached patch. Both GraphPropertyLabel and
> GraphLabelRef need to be placed in that section since both are
> primitive nodes.
Committed. (I reformatted the test query a little bit as you had
suggested upstream. Also, the ordering of the switch cases was slightly
different between the walker and the mutator, which I fixed.)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-05-04 15:41:15 | Re: problems with toast.* reloptions |
| Previous Message | Lukas Fittl | 2026-05-04 15:22:26 | Re: EXPLAIN: showing ReadStream / prefetch stats |