Re: [Patch]Add Graph* node support to expression_tree_mutator

From: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [Patch]Add Graph* node support to expression_tree_mutator
Date: 2026-04-30 06:44:13
Message-ID: CAExHW5t5_xs7sc0H2dT+QUsfEiNfTLtFKpCEE0Wr9ovF23dqoQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 30, 2026 at 2:17 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>

Thanks for reviewing the patch.

> Thanks for working on this. I ran into it independently today, and
> then discovered this thread. In expression_tree_mutator_impl,
> T_GraphLabelRef can be added to the "Primitive node types with no
> expression subnodes" section just as was done in
> expression_tree_walker_impl.

Right. Fixed in the attached patch. Both GraphPropertyLabel and
GraphLabelRef need to be placed in that section since both are
primitive nodes.

--
Best Wishes,
Ashutosh Bapat

Attachment Content-Type Size
v20260430-0001-Handle-nodes-that-may-appear-in-GraphPatte.patch text/x-patch 6.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ayush Tiwari 2026-04-30 06:46:35 Re: [PATCH] Fix stale relation close in sequence synchronization
Previous Message Chao Li 2026-04-30 06:40:21 Re: Fix a server crash problem from pg_get_database_ddl