| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Greg Burd <greg(at)burd(dot)me>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add tests for Bitmapset |
| Date: | 2025-10-03 08:25:58 |
| Message-ID: | 197CAFC2-963B-4414-9A51-08AF648146E4@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 3 Oct 2025, at 01:36, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Fri, 3 Oct 2025 at 01:33, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> Another nitpick would be to remove the test for NULL in test_bms_make_singleton
>> since that is a STRICT function, making the test for NULL superfluous code:
>
> I see test_random_operations() is also strict. Is it worth getting rid
> of the SQL NULL checks on the inputs there too? Aka, the attached.
Indeed, but reading the code I wonder if STRICT was a mistake and the intention
was to allow NULL input? That being said, the function is never called with
NULL so that's mostly academic thinking. +1 for removing the NULL checks and
simplifying the code.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chengpeng Yan | 2025-10-03 09:10:35 | Re: Allow virtual columns in index expressions or predicate |
| Previous Message | Michael Paquier | 2025-10-03 08:24:29 | Re: Sequence Access Methods, round two |