| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: CREATE SUBSCRIPTION ... SERVER vs. pg_dump, etc. |
| Date: | 2026-08-10 15:11:27 |
| Message-ID: | 1927407.1786374687@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> On Sun, 2026-08-09 at 22:15 -0400, Tom Lane wrote:
>> AFAICS, it's right: if stmt->servername is set while opts.connect is
>> not, we'll arrive at this step with serverid filled in but conninfo
>> still NULL. Even if there's some upstream reason why that
>> combination can't occur, this is pretty fragile-looking code.
> The code relies on the grammar setting either stmt->servername or stmt-
> >conninfo, but not both. I agree that the control flow shouldn't rely
> on that, and the code could be more clear anyway. Patch attached.
Looks good to me, I guess we'll have to see whether it satisfies
Coverity. (But if not, we can just dismiss that complaint.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bryan Green | 2026-08-10 15:12:50 | Re: [PATCH] Make select_views regression test output deterministic |
| Previous Message | Jeff Davis | 2026-08-10 15:04:19 | Re: CREATE SUBSCRIPTION ... SERVER vs. pg_dump, etc. |