Re: enable fallthrough warnings on clang

Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> I have committed this patch set. I also added a test into the C++ module.

BF member ayu is failing said test:

ccache clang++-4.0 -std=gnu++11 -Wall -Wpointer-arith -Werror=vla -Wmissing-format-attribute -Wimplicit-fallthrough -Wformat-security -fno-strict-aliasing -fwrapv -g -O2 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -I. -I. -I../../../../src/include -D_GNU_SOURCE -I/usr/include/libxml2 -c -o test_cplusplusext.o test_cplusplusext.cpp
test_cplusplusext.cpp:66:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
case 2:
^
test_cplusplusext.cpp:66:3: note: insert '[[clang::fallthrough]];' to silence this warning
case 2:
^
[[clang::fallthrough]];
test_cplusplusext.cpp:66:3: note: insert 'break;' to avoid fall-through
case 2:
^
break;
1 warning generated.

I don't know if it's worth catering to this extremely old
clang version ...

regards, tom lane