[PATCH v1] Fix tab completion for concurrent materialized view refresh

From: Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: [PATCH v1] Fix tab completion for concurrent materialized view refresh
Date: 2026-10-13 03:54:57
Message-ID: CAG7L5+7JOn_tjLjS1PJFTARtEybeJ1-aAAftZZ5L25_QZrjP4w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

psql currently suggests `WITH NO DATA` for
`REFRESH MATERIALIZED VIEW CONCURRENTLY`, although the backend rejects
that combination [1].

The attached patch offers only `DATA` after concurrent `WITH` and removes
`DATA` completion after a manually entered concurrent `WITH NO`.
Nonconcurrent refresh completion remains unchanged.

[1]
https://github.com/postgres/postgres/blob/8e82d6610e7280d7870c0c36ff1c797e3cfb3e09/src/backend/commands/matview.c#L209-L214

Kind regards,
Sho Ito

--
=======================================
*Sho Ito (Sean)*

E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/
<https://www.linkedin.com/in/sho-ito-0628/>*
GitHub: https://github.com/sean0628/
=======================================

Attachment Content-Type Size
v1-0001-Fix-tab-completion-for-concurrent-materialized-vi.patch application/octet-stream 1.3 KB

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2026-10-13 04:02:57 Re: [PG19] Bugs found comparing 19 with 18, list before I open threads
Previous Message shihao zhong 2026-10-13 03:50:08 [PG19] btree_gin misses rows for a timestamptz bound in the repeated DST hour