| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Noah Misch <noah(at)leadboat(dot)com> |
| Subject: | Re: recovery test failures on hoverfly |
| Date: | 2021-06-11 14:37:21 |
| Message-ID: | 1880199.1623422241@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Fri, Jun 11, 2021 at 05:38:34PM +0530, Amit Kapila wrote:
>> It seems the error happens in both the tests when after issuing a
>> KILL, we are trying to reconnect. Can we do anything for this?
> This is the same problem as c757a3da and 6d41dd0, where we write a
> query to a pipe but the kill, causing a failure, makes the test fail
> with a SIGPIPE in IPC::Run as a query is sent down to a pipe.
Indeed.
> I think that using SELECT 1 to test if the server has been restarted
> is a bit crazy. I would suggest to use instead a loop based on
> pg_isready.
The precedent of the previous fixes would seem to suggest seeing if
we can replace 'SELECT 1' with "undef". Not sure if that'll work
without annoying changes to poll_query_until, though.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-06-11 14:46:45 | Re: Race condition in recovery? |
| Previous Message | Fabien COELHO | 2021-06-11 14:09:10 | Re: Error on pgbench logs |