Re: Header and comments describing routines in incorrect shape in visibilitymap.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: Header and comments describing routines in incorrect shape in visibilitymap.c
Date: 2016-07-07 16:18:46
Message-ID: 18783.1467908326@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Regarding the first hunk, I don't like these INTERFACE sections too
> much; they get seriously outdated over the time and aren't all that
> helpful anyway. See the one on heapam.c for example. I'd rather get
> rid of that one instead of patching it. The rest, of course, merit
> revision.

+1, as long as we make sure that any useful info therein gets migrated
to the per-function header comments rather than dropped. If there's
anything that doesn't seem to fit naturally in any per-function comment,
maybe move it into the file header comment?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pete Stevenson 2016-07-07 16:45:01 MVCC overheads
Previous Message Tom Lane 2016-07-07 15:55:48 Re: EXPLAIN ANALYZE for parallel query doesn't report the SortMethod information.