| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <rhaas(at)postgresql(dot)org> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Introduce dynamic shared memory areas. |
| Date: | 2016-12-05 16:37:17 |
| Message-ID: | 18166.1480955837@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
>> Introduce dynamic shared memory areas.
gaur finds another problem with dsa.c: it uses SIZE_MAX which AFAICS
is not required to exist by POSIX.
We could adopt the timezone code's workaround
#ifndef SIZE_MAX
#define SIZE_MAX ((size_t) -1)
#endif
but I don't find that particularly nice, and in any case I wonder
why we would want to use SIZE_MAX and not MaxAllocHugeSize. The
overflow hazards that motivate that not being the max possible
value seem relevant here too.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-12-05 16:49:45 | pgsql: Fix race introduced by 6d46f4783efe457f74816a75173eb23ed8930020. |
| Previous Message | Robert Haas | 2016-12-05 16:04:19 | pgsql: Assorted documentation improvements for max_parallel_workers. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2016-12-05 16:38:06 | Re: Time to retire Windows XP buildfarm host? |
| Previous Message | Robert Haas | 2016-12-05 16:30:04 | Re: Hash Indexes |