Re: Changing the state of data checksums in a running cluster

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tomas Vondra <tomas(at)vondra(dot)me>, Andres Freund <andres(at)anarazel(dot)de>, Bernd Helmle <mailings(at)oopsware(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Michael Banck <mbanck(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Changing the state of data checksums in a running cluster
Date: 2026-04-08 20:10:44
Message-ID: 17BD06EB-3741-4921-AF60-6575FB4784ED@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 8 Apr 2026, at 10:31, SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com> wrote:
> On Fri, Apr 3, 2026 at 8:33 AM Daniel Gustafsson <daniel(at)yesql(dot)se <mailto:daniel(at)yesql(dot)se>> wrote:
>> The attached rebase with a PG_CONTROL_VERSION bump is what I have staged for
>> later tonight, submitting here to have the (hopefully) final patch archived as
>> well as another CFBot run.
>
> Sorry for the late review.

No need to apologise, reviewing already committed features is one of the most
valuable contributions there is. Thank you for looking!

> pg_enable/disable_data_checksums() aren't needed to be run
> on the standby. It appears the call would silently register a dynamic background worker that
> could never start , and could unexpectedly fire after promotion.

I think this is correct, and the right fix. Since I am travelling right now I
am a bit cautious with applying code changes, so I have this one staged for
when I get back. I'll re-review, test and might add a test for it as well when
I am back in the office in Monday.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2026-04-08 20:40:03 Re: Add pg_stat_autovacuum_priority
Previous Message Daniel Gustafsson 2026-04-08 20:03:28 Re: DOCS: Update data_checksums documentation to reflect enum change